Register restart for resume #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
Nov 15, 2023
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Nov 29, 2023
| // The above was omitted initially as a security precaution to ensure that user input to '--log' wouldn't be passed directly to ShellExecute | ||
| ShellExecute(NULL, NULL, Runtime::GetPathTo(Runtime::PathName::DefaultLogLocation).wstring().c_str(), NULL, NULL, SW_SHOWNORMAL); | ||
| } | ||
| if (Settings::ExperimentalFeature::IsEnabled(Settings::ExperimentalFeature::Feature::Reboot) && |
There was a problem hiding this comment.
If the context is terminated (not with an exception, but "normally"), this code will still run. That may or may not be correct, but I want to make sure it is considered. It feels ok, but then I worry that it won't happen for an exception. I would say that we haven't been strict on the precise method for failures to propagate, which means that this code is likely to not run in some situations when it probably should.
Since this is experimental, it is fine to live here for now. But it will be good to keep this in mind.
JohnMcPMS
reviewed
Dec 6, 2023
JohnMcPMS
approved these changes
Dec 6, 2023
|
@microsoft-github-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3165
Changes:
maxResumesthat limits the number of times a resume state can be "resumed". This is to ensure that continuous reboots don't occur.--waitargument is processed so that the user is prompted to continue before a reboot is kicked off.Microsoft Reviewers: Open in CodeFlow