-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Microsoft.WinGet.Client E2E test to Pester framework #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This comment has been minimized.
This comment has been minimized.
ryfu-msft
reviewed
Aug 11, 2023
azure-pipelines.yml
Outdated
@@ -335,6 +350,13 @@ jobs: | |||
TargetFolder: '$(artifactsDir)\PowerShell' | |||
condition: succeededOrFailed() | |||
|
|||
- task: CopyFiles@2 | |||
displayName: 'Copy PowerShell AnCPU Module Files' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
displayName: 'Copy PowerShell AnCPU Module Files' | |
displayName: 'Copy PowerShell AnyCPU Module Files' | |
ryfu-msft
previously approved these changes
Aug 11, 2023
ryfu-msft
approved these changes
Aug 11, 2023
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally uses all the refactor to run the Microsoft.WinGet.Client PowerShell module in Pester. The tests are done in the BuildPowerShellModule phase.
The E2E Test Source is built in the build phases, then it will be get published as artifacts under
E2ETests\TestLocalIndex'. Other artifacts that are required as published in
E2ETests` as well. Having the test source as a build artifacts will make it easier to perform repros without building the source all over again.The BuildPowerShellModule phase will download the artifacts, move necessary files to around, install the dev package (and dependencies), start the localhost web server and run the Pester tests. Then it will publish the modules as it used to as well as the test results.
It is important to remember the modules published as artifacts target the dev package, so one cannot just download it and use it without it.
I port all the E2E tests to Pester tests except the ones dealing with the server shutdown.
Eventually we will run tests for Microsoft.WinGet.DSC and Microsoft.WinGet.Configuration.
Microsoft Reviewers: codeflow:open?pullrequest=#3503