-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade 1.6 schema to 2020-12 #3478
Conversation
/azp run |
No commit pushedDate could be found for PR 3478 in repo microsoft/winget-cli |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Does this still work in Visual Studio Code? I think they only "support" an earlier version of JSON schemas. |
I don't know if this would have any impact on any of the rest of our validation code or not. I'll let one of the engineers review first. |
It looks like we should go with $defs There weren't examples in the 09 schema, but there were a few in the 12 schema under: |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This does not upgrade the Settings Schema as it is not reliably versioned
and it also does not upgrade the packages schema, as I felt it was not appropriate to create an entirely new schema version just for a base schema upgrade
The reason for changing to
defs
is based on the semi-incompatibility from draft 2019-09 and for better adherence to the standard.Microsoft Reviewers: codeflow:open?pullrequest=#3478