You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work for renaming whenever the portable is a loose binary, or when it is not inside of a directory in a zip file. With the way directory extraction works with Zip files, I wasn't able to add just a file entry to move the file since the Desired State entries are not guaranteed to process in order. I'd like some guidance on how that should be handled, perhaps that should be a separate PR?
Microsoft Reviewers: codeflow:open?pullrequest=#3439
After discussing with the team, we want this change to be included in the next release as a hotfix for the single portable symlink bug. The portable install for the archive scenario is quite complicated and will need to be addressed in our 1.7 release. If you can resolve the merge conflicts and get the build passing, we'll go ahead and check this one in. Thanks for your help!
After discussing with the team, we want this change to be included in the next release as a hotfix for the single portable symlink bug. The portable install for the archive scenario is quite complicated and will need to be addressed in our 1.7 release. If you can resolve the merge conflicts and get the build passing, we'll go ahead and check this one in. Thanks for your help!
Sounds good. I'll get it rebased later tonight and see what happens!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should work for renaming whenever the portable is a loose binary, or when it is not inside of a directory in a zip file. With the way directory extraction works with Zip files, I wasn't able to add just a file entry to move the file since the Desired State entries are not guaranteed to process in order. I'd like some guidance on how that should be handled, perhaps that should be a separate PR?
Microsoft Reviewers: codeflow:open?pullrequest=#3439