Use FolderId_ProgramFiles for non x86 default machine portable folder #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! Sorry for not considering the emulated case |
msftrubengu
approved these changes
Apr 8, 2023
|
After more investigation, I feel this fix is just hiding some potential failures. I need to trace back to see why this code assumes either x86 or x64. if a portable package is arm64, it should not be put under Program Files(x64) on an arm64 machine. Edit: on arm64 machines Program Files folder contain both x64 and arm64 apps. I think the correct fix may just be fall back to FolderId_ProgramFiles |
This reverts commit 1b563e3.
yao-msft
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change keeps existing behavior for x64 and arm64. On x86 machines, both point to C:\program files, and it's not breaking (actually the else part will not even be triggered).
Microsoft Reviewers: Open in CodeFlow