Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework extra packaged files mechanism #3064

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Mar 11, 2023

Learn more of the dark arts of msbuild syntax ✔️
Use that to implement recursive copying of files into the package ✔️

Change

This change is only to how we pull files into the package for development purposes. It better uses an ItemGroup and properties to enable the addition of files/directories by only adding one additional item, rather than 3 properties, 2 items, 1 message and 1 error.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner March 11, 2023 00:44
@JohnMcPMS
Copy link
Member Author

The package on the pipeline artifacts works! 🎊 🚢 🍰

@JohnMcPMS JohnMcPMS merged commit a47013a into microsoft:master Mar 16, 2023
@JohnMcPMS JohnMcPMS deleted the rework-packagefiles branch March 16, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants