-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration commands #3036
Configuration commands #3036
Conversation
This comment has been minimized.
This comment has been minimized.
Related to: |
This reverts commit a7f244a.
@@ -12,7 +12,7 @@ namespace Microsoft.Management.Configuration.UnitTests.Helpers | |||
/// <summary> | |||
/// A test implementation of IConfigurationProcessorFactory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -14,7 +14,7 @@ namespace Microsoft.Management.Configuration.Processor | |||
/// ConfigurationProcessorFactory implementation. Does not support out-of-proc. | |||
/// TODO: change to IConfigurationSetProcessorFactory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
@@ -0,0 +1,33 @@ | |||
using Microsoft.Management.Configuration.Processor; | |||
using System.Runtime.InteropServices; | |||
using WinRT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you'll hate me, but can you add stylecops :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😡
…ld error" This reverts commit 0b0794f.
…nfig winmd in processor
This comment has been minimized.
This comment has been minimized.
…ssor build error"" This reverts commit b17b2cb.
As is blatantly obvious from the commit count and messages, the build server has been difficult. While I don't think that the project setup is workable for running tests on the build server yet, I think that we need to be able to carry this through to the internal build to work out the issues for selfhosting purposes. Those fixes will then be applied here and hopefully enable E2E testing to occur soon. Since the local builds work, and this is a completely siloed experimental feature, these current shortcomings are acceptable to me. |
I agree since we're working on preview for an experimental feature. |
Change
Adds the configuration commands
configure
,configure show
,configure test
, andconfigure validate
(although it doesn't actually implementtest
orvalidate
).configure show
outputs the configuration file that it is given, along with information on the configuration units contained within. With the current PS DSC processor implementation, an example configuration file (that doesn't actually do anything as it is missing settings):is shown as:
configure
will first show the configuration file, then prompt the user to both review it and accept the responsibility for its actions.--accept-configuration-agreements
can pre-accept the warning and apply the configuration without prompting. As the configuration is being applied, the individual results will be reported.All of the configuration actions are run in a separate process to isolate winget.exe from a potential crash. That process is run at the same integrity level as winget.exe though, allowing elevated (admin) configuration actions.
Additionally, there are several minor fixes to things that I saw while developing this.
Validation
Currently this has only been manually validated (the command workflow; the configuration code has automated tests). Tests will be backfilled for this, but for now we are trying to get this into selfhost. As it is an experimental feature and also completely new, this seems like an acceptable, temporary state to be in.
Microsoft Reviewers: Open in CodeFlow