Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings.schema.0.2.json to include pinning feature #2961

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

florelis
Copy link
Member

@florelis florelis commented Feb 14, 2023

Add the "pinning" experimental feature to the settings file JSON schema to make it discoverable.

Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner February 14, 2023 19:43
@Trenly
Copy link
Contributor

Trenly commented Feb 14, 2023

Unrelated to this PR - Is there a reason that the settings schema is still at 0.2? I'm just surprised that it doesn't have supported versions of the schema per client like the manifests do

@denelon
Copy link
Contributor

denelon commented Feb 14, 2023

We need to add that to the checklist so we can support versioned schemas. Great call out @Trenly!

@florelis florelis merged commit d2f12c2 into master Feb 14, 2023
@yao-msft
Copy link
Contributor

Unrelated to this PR - Is there a reason that the settings schema is still at 0.2? I'm just surprised that it doesn't have supported versions of the schema per client like the manifests do

Currently the schema is more of informational only and not enforced by client code. Client will read settings as much as it understands. That's probably why we did not bother updating the schema version in the past.

@florelis florelis deleted the pinning-settings-update branch May 25, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants