Expose Agreements and Locale Fields in COM #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 24, 2023 11:11
Trenly
reviewed
Jan 31, 2023
| Windows::Foundation::Collections::IVector<winrt::Microsoft::Management::Deployment::Documentation> m_documentations{ nullptr }; | ||
| Windows::Foundation::Collections::IVector<hstring> m_tags{ nullptr }; | ||
| #endif | ||
| }; |
JohnMcPMS
requested changes
Jan 31, 2023
JohnMcPMS
previously requested changes
Feb 6, 2023
JohnMcPMS
dismissed
their stale review
API looks good, but I haven't reviewed implementation.
yao-msft
reviewed
Mar 2, 2023
| var installResult = await this.packageManager.InstallPackageAsync(searchResult.CatalogPackage, installOptions); | ||
|
|
||
| // Assert | ||
| Assert.AreEqual(InstallResultStatus.CatalogError, installResult.Status); |
There was a problem hiding this comment.
Changed to new error - 'PackageAgreementsNotAccepted'
yao-msft
reviewed
Mar 3, 2023
yao-msft
reviewed
Mar 8, 2023
yao-msft
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR expose all of the locale fields including agreements. Also provides a way for the COM caller to accept or reject package/source agreements. To avoid breaking existing usage, the default behavior for accepting source/package agreements has been set to true.
Changes:
AcceptPackageAgreements(bool)AcceptSourceAgreements(bool)GetCatalogPackageMetadata()with no parameters uses the default localization, whileGetCatalogPackageMetadata(string locale)applies the specified locale and retrieves those locale fields.Tests:
Added tests to verify that all locale fields and agreements are outputted correctly.
Microsoft Reviewers: Open in CodeFlow