-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block msix provisioning api calls where known OS bugs exist #2855
Conversation
// Remove this check when the OS bug is fixed and back ported. | ||
if (!Runtime::IsRunningAsSystem()) | ||
{ | ||
context.Reporter.Error() << Resource::String::InstallFlowReturnCodeSystemNotSupported << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That string is "The current system configuration does not support the installation of this package." If I saw that I would think the package is not supported at all, but I would like to know that I may at least be able to install it without admin privileges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only applicable case where this will succeed is the InProcCom with system context. And for InProcCom, reporter strings are not reported. This is here mainly for consistency and for local system context testing. This will be cherry picked as hot fix for our second release candidate and we'd prefer not have a loc update to get it delayed, so if we are not happy with this string, I can just remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about PendingWorkError
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with keeping it as-is
Related OS bugs have been filed.
Microsoft Reviewers: Open in CodeFlow