Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block msix provisioning api calls where known OS bugs exist #2855

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Jan 14, 2023

  • msix provision and deprovision apis under packaged context
  • msstore provision apis under admin context

Related OS bugs have been filed.

Microsoft Reviewers: Open in CodeFlow

@yao-msft yao-msft requested a review from a team as a code owner January 14, 2023 02:59
// Remove this check when the OS bug is fixed and back ported.
if (!Runtime::IsRunningAsSystem())
{
context.Reporter.Error() << Resource::String::InstallFlowReturnCodeSystemNotSupported << std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That string is "The current system configuration does not support the installation of this package." If I saw that I would think the package is not supported at all, but I would like to know that I may at least be able to install it without admin privileges.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only applicable case where this will succeed is the InProcCom with system context. And for InProcCom, reporter strings are not reported. This is here mainly for consistency and for local system context testing. This will be cherry picked as hot fix for our second release candidate and we'd prefer not have a loc update to get it delayed, so if we are not happy with this string, I can just remove this line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about PendingWorkError?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with keeping it as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants