Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return localization independent string for help links #2786

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Return localization independent string for help links #2786

merged 3 commits into from
Dec 20, 2022

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Dec 20, 2022 •
edited by ghost
Loading

  • Updated HelpLink return type to a localization independent string.
Microsoft Reviewers: Open in CodeFlow

@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner December 20, 2022 17:57
florelis
florelis approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@florelis florelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use LocIndView instead of LocIndString?

@AmelBawa-msft AmelBawa-msft merged commit 7cc5068 into microsoft:master Dec 20, 2022
@AmelBawa-msft AmelBawa-msft deleted the loc-ind-part-2 branch December 20, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florelis florelis florelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmelBawa-msft @florelis