-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tests in Workflow.cpp
into multiple files
#2773
Conversation
# Conflicts: # src/AppInstallerCLITests/WorkFlow.cpp
…ty related group policies"
…d context commenting"
It would be so nice if git could see that I'm just moving code around and it could apply the changes automatically instead of having to do it by hand :( If we want to take this, can we merge it before I get more conflicts?
|
return result; | ||
} | ||
|
||
SearchResult WorkflowTestCompositeSource::Search(const SearchRequest& request) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also want to split this function, I may do it later in another PR.
The actual reason for the test failures was fun to find. There were some test hook overrides that were being set and never cleared when the test using them was done. So subsequent tests would still get the behavior from the override. Moving the tests around changed the order and revealed that. Since it was about a test hook override set at runtime, it would only show if executing the two relevant tests in the same invocation and in a specific order. Not having the fix for export settings was just a red herring. (I'll be mad if after this the tests still fail...) |
I've always disliked how big this file is, having tests for all flows. I didn't want to add even more to it for pinning, so I'm splitting it up :)
[ExportFlow]
toExportFlow.cpp
. Tests that were the only ones with that tag, I left inWorkflow.cpp
WorkflowCommon.h
andWorkflowCommon.cpp
with just the shared test source/context definition, and common task overrides.#include
s andusing
sMicrosoft Reviewers: Open in CodeFlow