Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest (Msix) installer validation - Try parsing package version #2692

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Manifest (Msix) installer validation - Try parsing package version #2692

merged 2 commits into from
Nov 11, 2022

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Nov 11, 2022 •
edited by ghost
Loading

What was done?

  • Report an error message if the package version could not be parsed to UINT64 during the manifest (Msix) installer validation, instead of throwing an exception.

Test

  • Added unit test
Microsoft Reviewers: Open in CodeFlow

@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner November 11, 2022 18:12
yao-msft
yao-msft approved these changes Nov 11, 2022
View reviewed changes
src/AppInstallerCLITests/YamlManifest.cpp Outdated Show resolved Hide resolved
src/AppInstallerCommonCore/Manifest/MsixManifestValidation.cpp Outdated Show resolved Hide resolved
@AmelBawa-msft AmelBawa-msft merged commit ae32774 into microsoft:master Nov 11, 2022
@AmelBawa-msft AmelBawa-msft deleted the manifest-installer-validation-version-parse branch November 11, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmelBawa-msft @yao-msft