Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enable/disable admin settings if group policy prevents it #2683

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Don't enable/disable admin settings if group policy prevents it #2683

merged 3 commits into from
Nov 15, 2022

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Nov 8, 2022 •
edited by ghost
Loading

What was done?

  • If an admin setting was disabled by a group policy, and user attempts to enable it using winget settings --enable, then report an error message.
  • Similarly, if an admin setting was enabled by group policy, and user attempts to disable it using winget settings --disable, then report an error message.

Test?

  • Added tests covering the various state combinations.
Microsoft Reviewers: Open in CodeFlow

@AmelBawa-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review November 9, 2022 22:10
@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner November 9, 2022 22:10
yao-msft
yao-msft approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AmelBawa-msft AmelBawa-msft merged commit caadda4 into microsoft:master Nov 15, 2022
@AmelBawa-msft AmelBawa-msft deleted the admin-settings-group-policy branch November 15, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmelBawa-msft @yao-msft