Enable mechanism for some control over correlation #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
reviewed
Oct 6, 2022
| if ($MetadataCollection) | ||
| { | ||
| $wingetUtilPath = Join-Path $PSScriptRoot "WinGetUtil.dll" | ||
| $installAndCorrelationExpression = -join($installAndCorrelationExpression, ' -meta "', $wingetUtilPath, '" -sys32 "', $System32Path,'"') |
yao-msft
reviewed
Oct 6, 2022
| // Number of changed ARP entries that match the installed package | ||
| size_t CountOfIntersectionOfChangesAndMatches{}; | ||
|
|
||
| ARPCorrelationResult& operator=(ARPHeuristicsCorrelationResult&& other) |
There was a problem hiding this comment.
Honestly, I was surprised it didn't work out of the box. The goal is to be able to assign just the base portion of the object, which seems very intuitive to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
The primary change is to enable some control over the correlation functionality so that different situations can behave differently. Specifically, the utility functionality of metadata collection, which is intended to be run in a "clean room" environment, can assume that a single change to ARP represents the target entry.
In addition, this change enables diagnostic information to be output by the metadata collection. This includes the reason that an entry was chosen, and the confidence value for various possible entries if the heuristic matching is attempted.
Finally, the correlation testbed is enhanced to run the metadata collection, allowing it to be tested alongside the inline correlation. The scripts have various improvements, such as a
-Waitto leave the sandbox active and forcing the CSV to be output with a UTF8-BOM (Excel requires the BOM in order to open the CSV as UTF8).Microsoft Reviewers: Open in CodeFlow