Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Symlink Target Canonical #2563

Merged
merged 5 commits into from
Sep 30, 2022
Merged

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Sep 30, 2022


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner September 30, 2022 01:38
@Trenly Trenly changed the title Make Symlink Target Lexically Normal Make Symlink Target Canonical Sep 30, 2022
@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 30, 2022
@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Sep 30, 2022

RIP. I can't see which ones are failing

@yao-msft
Copy link
Contributor

It's failing at VerifySymlink unit tests. I can give it a try and see if I can get a quick fix.

src/AppInstallerCommonCore/Filesystem.cpp Outdated Show resolved Hide resolved
src/AppInstallerCommonCore/Filesystem.cpp Outdated Show resolved Hide resolved
@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Sep 30, 2022

You fixed it!

@yao-msft yao-msft merged commit 8d0996f into microsoft:master Sep 30, 2022
@Trenly Trenly deleted the LexicallyNormal branch October 1, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Portable In Zip does not uninstall correctly
3 participants