-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PortableIndex for tracking portable files #2459
Conversation
@check-spelling-bot ReportUnrecognized words, please review:
To accept these unrecognized words as correct, run the following commands... in a clone of the [email protected]:ryfu-msft/winget-cli.git repository
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not looked at portable index 1.0 or portable table 1.0 cpp files yet, but I might not be able to until tomorrow. Wanted to get these comments to you now.
src/AppInstallerRepositoryCore/Microsoft/Schema/IPortableIndex.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/IPortableIndex.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/IPortableIndex.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/IPortableIndex.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/PreIndexedPackageSourceFactory.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/AppInstallerRepositoryCore.vcxproj.filters
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/AppInstallerRepositoryCore.vcxproj.filters
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableIndexInterface_1_0.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableIndexInterface_1_0.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.cpp
Outdated
Show resolved
Hide resolved
{ | ||
SQLite::Builder::StatementBuilder builder; | ||
builder.Select(SQLite::RowIDName).From(s_PortableTable_Table_Name).Where(s_PortableTable_FilePath_Column); | ||
builder.Equals(path.u8string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added extension method "COLLATE NOCASE" to column builder as well as tests to verify that column is case-insensitive.
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.cpp
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/IPortableIndex.h
Outdated
Show resolved
Hide resolved
src/AppInstallerRepositoryCore/Microsoft/Schema/Portable_1_0/PortableTable.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
access for comting |
Related to: #140
This PR adds support for a PortableIndex which will be used to track the files/directories/symlinks that are placed down when installing portable(s) from an archive.
Changes:
Tests:
Microsoft Reviewers: Open in CodeFlow