-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove scope filter from being applied to portables #2383
Conversation
@@ -634,6 +659,7 @@ namespace AppInstaller::CLI::Workflow | |||
{ | |||
context << | |||
EnsureSymlinkCreationPrivilege << | |||
EnsureRunningAsAdminForMachineScopeInstall << |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like theres a duplicated call here, but only in certain scenarios. When dev mode is disabled, it checks for admin to ensure synlink creation, then checks for admin again if running a machine scope install.
I’m sure that this will work, I’m just wondering if maybe theres a better way to handle checking the elevation level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is less efficient, but EnsureSymlinkCreationPrivilege
is planned to be temporary, so it is easier to keep it separated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnsureSymlinkCreationPrivilege
is meant to be a temporary check to handle the special case where a user may have developer mode off. I expect that this check will be removed once we fully address this issue in 1.4, so I decided to keep these as separate checks for better clarity and cleanup in the near future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess I needed to refresh the page :)
If the --scope argument is present when installing a portable package, the command will fail if the incorrect scope is not present for a portable installer. This is the wrong behavior as the scope field in the manifest should not apply to portable packages.
To resolve this issue, I have removed the applied scope filter if the installerType is portable (and also for msix).
Changes:
Microsoft Reviewers: Open in CodeFlow