Add SYSTEM to explicit ACLs #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l access to Temp as that is where we install from.
ghost
added
the
Issue-Bug
yao-msft
reviewed
Jul 26, 2022
| EXPLICIT_ACCESS_W explicitAccess[2]; | ||
| // Configuring permissions for both CurrentUser and SYSTEM while not having owner set as one of them is not valid because | ||
| // below we use only the owner permissions in the case of running as SYSTEM. | ||
| if ((hasCurrentUser && hasSystem) && |
There was a problem hiding this comment.
There was a problem hiding this comment.
The point is to discover a configuration that would be illegal in that case without actually needing to be running as SYSTEM.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2365 (Hopefully... it actually worked fine on my machine before this change.)
Change
Add support for
SYSTEMto the explicit ACLs, and giveSYSTEMfull control on theTempdirectory.ApplyACLand the data that it uses are basically re-written to support a more dynamic list of ACEs. Also ensures that if the process is running asSYSTEM, it doesn't attempt to write the same ACE multiple times.Validation
Existing tests and a new unit test for this scenario. Manually ran as
SYSTEMto ensure that it does the correct thing.Microsoft Reviewers: Open in CodeFlow