Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Release Notes to new line and indent #2312

Merged
merged 6 commits into from
Jul 11, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jul 6, 2022

It bothered me that Multi-Line release notes had weird alignment. This places the release notes down one line and indents all lines.

image


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner July 6, 2022 23:00
Copy link
Member

@florelis florelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but I'd wait to see if @denelon or @JohnMcPMS like the new behavior.

src/AppInstallerCommonCore/AppInstallerStrings.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/ShowFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/ShowFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCommonCore/AppInstallerStrings.cpp Outdated Show resolved Hide resolved
@denelon
Copy link
Contributor

denelon commented Jul 8, 2022

I think it looks good.

@florelis
Copy link
Member

florelis commented Jul 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@florelis
Copy link
Member

florelis commented Jul 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS JohnMcPMS merged commit 23aae49 into microsoft:master Jul 11, 2022
@Trenly Trenly deleted the ReleaseNotesIndent branch July 11, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants