Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Wait upon command completion #2236

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Feat: Wait upon command completion #2236

merged 4 commits into from
Jul 6, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jun 10, 2022


Seems the argument was already there, just never implemented

  • Tested Manually
Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner June 10, 2022 05:26
@github-actions
Copy link

github-actions bot commented Jun 19, 2022

@check-spelling-bot Report

Unrecognized words, please review:

  • conio
  • getch
Previously acknowledged words that are now absent activatable amd Archs dsc enr FWW Globals hackathon lww mytool OSVERSION Packagedx parametermap symlink Uninitialize WDAG whatif wsb
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:Trenly/winget-cli.git repository
on the Wait branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/1159612838" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

@ghost ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Jun 20, 2022
src/AppInstallerCLICore/ExecutionReporter.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/ExecutionReporter.cpp Outdated Show resolved Hide resolved
@ghost ghost added Needs-Author-Feedback Issue needs attention from issue or PR author and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Jun 21, 2022
@JohnMcPMS
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JohnMcPMS
Copy link
Member

Sorry that this slipped through for the last two weeks...

@Trenly
Copy link
Contributor Author

Trenly commented Jul 6, 2022

Sorry that this slipped through for the last two weeks...

No worries; I figured someone would get to it eventually. Besides, you have more important stuff you're working on anyways

@JohnMcPMS JohnMcPMS merged commit a56372b into microsoft:master Jul 6, 2022
@Trenly Trenly deleted the Wait branch July 6, 2022 20:58
@denelon
Copy link
Contributor

denelon commented Jul 6, 2022

I kinda' have a pet feature riding on this one elsewhere, so I was excited to see the PR 😊

@denelon
Copy link
Contributor

denelon commented Jul 6, 2022

Time to cut 1.4-preview (1) I hope. 🤞

@denelon denelon linked an issue Jul 27, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add argument to pause after command execution "Pause" winget after it finished
4 participants