-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display documentations in show command #2212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider showing these in the event of an install
/upgrade
failure where we don't have an expected return code URL to show? @denelon again for consideration.
My thoughts are showing the return code in either case, and optionally the URL when one is present. If there isn't a URL there isn't much we can do. |
I don't think we should be showing the |
@ryfu-msft I misunderstood the ask. If it's just a "generic" documentation link, then no, we shouldn't show that URL if the install/upgrade failed. I thought we were referencing the URL associated with the expected return code. |
Resolves: #1984
Microsoft Reviewers: Open in CodeFlow