Fixed builds on VS 2022 version 17.2. #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedieaston
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those of us who
keep forgetting minor VS version bumps change the compilerenjoy living on the bleeding edge, Visual Studio 2022 was updated to version 17.2 this week, again breaking winget builds. This PR resolves the errors, by adding a missingtypenamekeyword in a couple places.The kicker is, I can't find a changelog (publicly) that mentions what changed to cause this. Nothing in the STL changelog looks to be it, and the conformance changes don't mention it either. This seems more correct anyway, so I think it is fine, but if anyone could shed some more light that would be great!
(My daily builds broke because GitHub Actions' image was updated this week. I believe hosted ADO pools use the same images, so I think the CI for this repo may have broken too? In any case, this fixes the issue.)
Microsoft Reviewers: Open in CodeFlow