fix passing null parameters to Find-WinGetPackage #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like I didn't get "--verbose-log" in there. Did I miss something? |
I don't see that in the original version. Maybe it wasn't added? |
|
That wouldn't surprise me! Would you mind adding it? |
From what I can tell is Invoke-WinGetCommand would need to have verbose logging support and I think that's outside my abilities to add. |
|
No worries then 😊. I'll try to remember to add it after this PR is resolved. |
This comment was marked as off-topic.
This comment was marked as off-topic.
denelon
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables all cmdlets in the module and makes Install-WinGetPackage actually work. There may be other stuff wrong with the other cmdlets but I didn't test the other ones thoroughly.
Microsoft Reviewers: Open in CodeFlow