Mitigate crash occuring in CompositeSource #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2016
(Really, mitigates, but github likes fixes)
Change
A crash is showing up in the installed version of the installed package being null. While this doesn't make sense, bugs don't have to! We need a live debug repro (or time travel trace) to get to the bottom of this, so for now we will just do our best to log details and skip the offending package. This is better than a crash for the user, but could lead to whatever is causing it to be missing in results. Reports of that will potentially lead us to the culprit, if it isn't a system state issue.
Microsoft Reviewers: Open in CodeFlow