Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AppsAndFeatures name and publisher #2042

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Mar 24, 2022

Change

Places the values from the AppsAndFeaturesEntries into the index, and uses them in the post-install ARP entry detection.

Validation

Added a test to ensure that the values were added and searched in a simple case.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner March 24, 2022 03:14
src/AppInstallerCLI.sln Outdated Show resolved Hide resolved
}
}

void AddNormalizedPublisher(const Utility::NameNormalizer& normalizer, const Manifest::string_t& publisher, std::vector<Utility::NormalizedString>& out)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AddNormalizedPublisher

nit: looks like this implementation is same as the AddNormalizedName above, shall we combine them like AddNormalizedValue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't, they use NormalizeName and NormalizePublisher respectively.

Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit d2a9c6d into microsoft:master Mar 24, 2022
@JohnMcPMS JohnMcPMS deleted the aaf-impl branch March 24, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants