Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename source auto update group policy #1995

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Conversation

florelis
Copy link
Member

@florelis florelis commented Mar 3, 2022

From internal review of the group policies, we are removing "InMinutes" from the name of the policy SourceAutoUpdateIntervalInMinutes. This updates the policy definition with the new name, and changes to read the policy from the new registry value (while respecting the old value for compatibility). Updated the tests to use the new value name, and added tests for respecting the old name.

Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner March 3, 2022 00:43
@yao-msft
Copy link
Contributor

yao-msft commented Mar 3, 2022

    case TogglePolicy::Policy::Settings: return

nit: this return is misaligned


Refers to: src/AppInstallerCommonCore/GroupPolicy.cpp:241 in 028cbe9. [](commit_id = 028cbe9, deletion_comment = False)

@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Mar 3, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Mar 7, 2022
@florelis florelis requested a review from JohnMcPMS March 10, 2022 01:07
@florelis florelis merged commit e50f66b into microsoft:master Mar 10, 2022
@florelis florelis deleted the inMinutes branch May 28, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants