Remove duplicated message when no upgrades #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1986 in repo microsoft/winget-cli |
yao-msft
reviewed
Mar 1, 2022
| @@ -759,7 +759,12 @@ namespace AppInstaller::CLI::Workflow | |||
|
|
|||
| if (table.IsEmpty()) | |||
| { | |||
| context.Reporter.Info() << Resource::String::NoInstalledPackageFound << std::endl; | |||
| if (m_onlyShowUpgrades) { | |||
| context.Reporter.Info() << Resource::String::UpdateNotApplicable << std::endl; | |||
There was a problem hiding this comment.
I think we still want to differentiate "app not installed" vs "update not applicable". This change seems ok with winget upgrade --all, but we want clearer message for winget upgrade <specific package>
If we want to avoid showing "app not installed" for winget upgrade --all, it would be done as not triggering this reporting.
There was a problem hiding this comment.
Got it. I restored the original message, but at least removed the duplication. What do you think?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a follow up of #1982, continuing the cleanup. But this is a bit different because it also changes one message.
This is how it was before:
This is how it is now:
Please let me know what you think.
Microsoft Reviewers: Open in CodeFlow