Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Only include unknown packages which exist in source #1972

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fix: Only include unknown packages which exist in source #1972

merged 1 commit into from
Feb 24, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Feb 24, 2022 •
edited
Loading

This also will only include packages which can be / have been disambiguated

cc @jedieaston

Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner February 24, 2022 16:45
@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Feb 24, 2022
@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jedieaston
jedieaston approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@jedieaston jedieaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was it? 🤦‍♂️

thanks for figuring it out :D

@Trenly
Copy link
Contributor Author

Trenly commented Feb 24, 2022

That was it? 🤦‍♂️

thanks for figuring it out :D

I think that was it; Seemed to do the check when I tested manually

@denelon denelon merged commit 647b285 into microsoft:master Feb 24, 2022
@Trenly Trenly deleted the FixUnknownCount branch February 24, 2022 22:45
@jedieaston jedieaston mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denelon denelon denelon approved these changes

@jedieaston jedieaston jedieaston approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--include-unknown not functioning as expected
4 participants
@Trenly @yao-msft @jedieaston @denelon