Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting for Logging Level #1945

Merged
merged 5 commits into from
Feb 17, 2022
Merged

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Feb 16, 2022

Resolves #1940

This is my first time really digging into the codebase, so I wouldn't be surprised if this is entirely incorrect.
This PR allows users to set their preferred logging level to any of the levels available with the default remaining Info. This preference is overridden by the use of --verbose-logs

Tested: Manually + Unit Tests


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner February 16, 2022 03:35
@ghost ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Feb 16, 2022
@Trenly Trenly changed the title Verbose log setting Setting for Logging Level Feb 16, 2022
@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Feb 16, 2022

@denelon - Another instance of CLA outage;
Previous PR's - https://github.com/microsoft/winget-cli/pulls?q=is%3Apr+author%3ATrenly and all of the winget-pkgs ones

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Feb 16, 2022

Putting this here as CLA verification -
image

image

@yao-msft
Copy link
Contributor

Let me try close and reopen. If this does not work, I'll have to edit project settings to override the policy.

@yao-msft yao-msft closed this Feb 17, 2022
@yao-msft yao-msft reopened this Feb 17, 2022
@ghost ghost added the Area-Settings Issue related to WinGet Settings label Feb 17, 2022
@yao-msft yao-msft merged commit a32078f into microsoft:master Feb 17, 2022
@Trenly Trenly deleted the VerboseLogSetting branch February 17, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issue related to WinGet Settings Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting for always using verbose logs
2 participants