Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of initial 1.2 schema with 'Portable' installerType #1930

Merged
merged 8 commits into from
Feb 26, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Feb 11, 2022

Changes:

  • Added initial 1.2 schema with new "portable" installerType

Tests:

  • Added 1.2 schema manifest tests
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner February 11, 2022 22:57
@yao-msft
Copy link
Contributor

yao-msft commented Feb 11, 2022

Looks like you forgot to add the schemas to the collection


In reply to: 1036735881

@ryfu-msft ryfu-msft marked this pull request as draft February 11, 2022 23:17
"type": [ "array", "null" ],
"items": {
"type": "object",
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is the "initial" schema, but any chance we could get the architecture key for PackageDependencies here per #1665?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedieaston I've run into a couple of cases where the dependencies aren't "natively" available for the architecture of the package. What would the intent be here? An optional "dependencyArchitecture" where the dependency needs to be other than the architecture of the installer? That's my best guess from reading #1665 and what I think I ran into trying to get Screen To Gif installed on ARM64.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be my thinking. Many times installers are one architecture, but they rely on dependencies for a different architecture. I've seen lots of applications where they are x64 but for whatever reason they require x86 versions of the VC Redists.

@ryfu-msft ryfu-msft changed the title Addition of initial 1.2 schema and settings schema fields for Portable installer support Addition of initial 1.2 schema with 'Portable' installerType Feb 16, 2022
@ryfu-msft ryfu-msft marked this pull request as ready for review February 16, 2022 01:44
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @yao-msft should probably sign off.

@ryfu-msft ryfu-msft merged commit c30ca05 into microsoft:master Feb 26, 2022
@ryfu-msft ryfu-msft deleted the updateSchema1_2 branch May 16, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants