-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of initial 1.2 schema with 'Portable' installerType #1930
Conversation
Looks like you forgot to add the schemas to the collection In reply to: 1036735881 |
"type": [ "array", "null" ], | ||
"items": { | ||
"type": "object", | ||
"properties": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is the "initial" schema, but any chance we could get the architecture key for PackageDependencies here per #1665?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedieaston I've run into a couple of cases where the dependencies aren't "natively" available for the architecture of the package. What would the intent be here? An optional "dependencyArchitecture" where the dependency needs to be other than the architecture of the installer? That's my best guess from reading #1665 and what I think I ran into trying to get Screen To Gif installed on ARM64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be my thinking. Many times installers are one architecture, but they rely on dependencies for a different architecture. I've seen lots of applications where they are x64 but for whatever reason they require x86 versions of the VC Redists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but @yao-msft should probably sign off.
Changes:
Tests:
Microsoft Reviewers: Open in CodeFlow