Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UnsupportedOSArchitectures manifest element #1807

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Add support for UnsupportedOSArchitectures manifest element #1807

merged 1 commit into from
Jan 5, 2022

Conversation

florelis
Copy link
Member

@florelis florelis commented Dec 16, 2021 •
edited by ghost
Loading

Adding support for UnsupportedOSArchitectures manifest entry by extending MachineArchitectureComparator to add a check that the system architecture is not listed as unsupported.

Closes #993

Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner December 16, 2021 03:05
@ghost ghost added Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client. labels Dec 16, 2021
ranm-msft
ranm-msft approved these changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@ranm-msft ranm-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@florelis florelis merged commit cfd8b29 into microsoft:master Jan 5, 2022
@florelis florelis deleted the unsupportedArchitectures branch May 28, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranm-msft ranm-msft ranm-msft approved these changes

Assignees
No one assigned
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identify installers that don't work under emulation
2 participants
@florelis @ranm-msft