Bug fix: PackageTrackingCatalog and SQLiteIndexUpdate #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageTrackingCatalog:
When dependency nodes are not found in the index, an attempt to add or update manifest by the catalog tracking feature causes a failure. In some scenarios this might be valid as the dependencies of a package might already be present in the user's machine. This fix totally disable dependencies for catalog tracking feature by adding an option to not create dependencies table and also checking for the presence of the table when there is an attempt to perform any operation on the table.
SQLiteIndexUpdate:
Bug in dependencies udpate manifest causes the method to always return true even if the index wasn't modified. This pull request fixes the issue, and also extends the update manifest tests to capture 1_4 schema update.
Microsoft Reviewers: Open in CodeFlow