First drafted client cmdlets from Hackathon 221 #1757
Conversation
ghost
added
the
Issue-Feature
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -19,6 +20,7 @@ apiset | |||
| appinstallertest | |||
| appname | |||
| Archs | |||
| arget | |||
There was a problem hiding this comment.
Some of these don't seem like legitimate words. Can you double check them? The spell checking doesn't work if we just put all of our typos in here 😄
There was a problem hiding this comment.
This was triggering on "-Target" for some reason
| @@ -0,0 +1,41 @@ | |||
| Function Enable-WinGetLocalManifest | |||
There was a problem hiding this comment.
These should probably be something like Set-WinGetAdminSetting -Setting LocalManifest -Value true rather than creating a new cmdlet for every setting.
There was a problem hiding this comment.
The PowerShell cmdlet structure tends to use Enable and Disable. It makes them more discoverable. Maybe someone from the community can weigh in on this one. @doctordns what do you think?
There was a problem hiding this comment.
I just expect the possibility of non-boolean values in the future, but it could also be Enable/Disable for booleans and Set in the future for non-booleans. But the larger takeaway is to make the actual setting that is being modified be a parameter rather than making new cmdlets per setting.
There was a problem hiding this comment.
Enable, in general moves a resource from a disabled to enabled state - Disable doing the opposite. I think, in general, I'd prefer Set - one command to set/unset vs two cmdlets (enable and disable). John is right - there could be some resources that need to be set to a non boolean value.
| @@ -0,0 +1,89 @@ | |||
| Function Uninstall-WinGetPackage{ | |||
There was a problem hiding this comment.
File name has _ rather than -.
|
I messed up my branch. I created a new Draft PR #1760 |
Closes #674
This is the first set of PowerShell cmdlets drafted during the 2021 Hackathon at Microsoft to explore PowerShell syntax for the Windows Package Manager. This is a very early draft and is subject to substantial change. Notes and historical context are in the README.md.
Microsoft Reviewers: Open in CodeFlow