-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Binskim error EnableCriticalCompilerWarnings (#4764)
Fixes a binskim error where sfsclient dependencies (curl -> ares) were not getting compiled with a warning level > 3 compiler flag. Added `/W3` to only the release triplets Verified that of WindowsPackageManager.dll no longer shows an error when running with binskim.
- Loading branch information
Showing
8 changed files
with
16 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE arm) | ||
| set(VCPKG_CRT_LINKAGE static) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE arm) | ||
| set(VCPKG_CRT_LINKAGE dynamic) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE arm64) | ||
| set(VCPKG_CRT_LINKAGE static) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE arm64) | ||
| set(VCPKG_CRT_LINKAGE dynamic) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE x64) | ||
| set(VCPKG_CRT_LINKAGE static) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE x64) | ||
| set(VCPKG_CRT_LINKAGE dynamic) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE x86) | ||
| set(VCPKG_CRT_LINKAGE static) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| set(VCPKG_TARGET_ARCHITECTURE x86) | ||
| set(VCPKG_CRT_LINKAGE dynamic) | ||
| set(VCPKG_LIBRARY_LINKAGE static) | ||
| set(VCPKG_C_FLAGS "/Qspectre") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre") | ||
| set(VCPKG_C_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_CXX_FLAGS "/Qspectre /W3") | ||
| set(VCPKG_BUILD_TYPE release) |