Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify support for non-Windows targets #3135

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Clarify support for non-Windows targets #3135

merged 2 commits into from
Jun 28, 2024

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Jun 28, 2024

The windows-rs project is focused on bringing the best of Windows to Rust developers. Various efforts to support non-Windows targets continue to make it too difficult to support Windows, which is the whole point of this project.

The position we're taking is to provide basic non-Windows compatibility for windows-core only to support COM and nothing more. Even this adds regrettable complexity to the windows-core crate, but this update at least attempts to make that complexity manageable by providing a simple way for us to partition what parts of windows-core is specific to Windows and what is cross-platform. Subsequent updates will limit more of the code that isn't required for COM support.

The test_linux crate covers what little support we offer for non-Windows targets. This is limited to windows-core and windows-result and is tested in linux.yml as part of each build.

Fixes: #3101
Fixes: #3083
Related: #3125

Copy link
Collaborator

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a good balance. Having support tightly scoped to only the essentials on non-Windows platforms still allows other parties to build on top of that if they wish. Just in a way that doesn't negatively impact windows-rs support for Windows.

crates/libs/core/src/imp/mod.rs Show resolved Hide resolved
@kennykerr kennykerr merged commit 66f1850 into master Jun 28, 2024
75 checks passed
@kennykerr kennykerr deleted the non-windows branch June 28, 2024 19:43
@kennykerr kennykerr mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COM can't be used on non-Windows platforms
4 participants