Detect unused `bindgen`/`riddle` filters #2634

kennykerr · 2023-08-28T17:38:06Z

As an example:

> riddle.exe -i windows.winmd -o output.rs -f Windows.Foundation.Rect WIndows !Windows.Fondation
error: unused filters
  Windows.Fondation
  WIndows

Fixes: #2630

ChrisDenton

Looks great to me! I also tried it on the rustc riddle PR and it showed up things that had been moved or removed. I'll update that when I have a mo.

This PR also has a few misc cleanups? Not complaining mind you.

riverar · 2023-08-28T19:04:44Z

crates/libs/bindgen/src/winmd/verify.rs

+            message.push_str(&format!("\n  {unused}"));
+        }
+
+        return Err(crate::Error::new(&message));


Surfacing these as errors versus warnings may make third-party crate maintenance harder than it needs to be. I can see a scenario where folks will want to add a preemptive filter for, say, X.Y.Z.Preview namespaces when they appear/don't appear during a dev cycle. Or simply don't care if they over-specify the filter list.

No change needed right now though, we can take the "lets see what happens" approach.

Personally, I do prefer the error because I'd like the filter list to reflect what goes into the generated bindings (no more, no less). But I accept that other people may have other preferences.

kennykerr · 2023-08-28T19:26:41Z

This PR also has a few misc cleanups?

Only some dead/commented code that I happened upon as well as hardening the tests to ensure that the filtering was working correctly.

kennykerr · 2023-08-28T19:28:05Z

Thanks for checking! I'll leave it like this for now and we can reevaluate in future as needed.

kennykerr added 2 commits August 28, 2023 12:32

unused

543de4d

test

ebf1b8b

kennykerr requested review from riverar and ChrisDenton August 28, 2023 18:01

test

d95e30f

kennykerr changed the title ~~Detect unused bindgen filters~~ Detect unused bindgen/riddle filters Aug 28, 2023

ChrisDenton approved these changes Aug 28, 2023

View reviewed changes

riverar approved these changes Aug 28, 2023

View reviewed changes

kennykerr merged commit 0b86626 into master Aug 28, 2023
47 checks passed

kennykerr deleted the unused branch August 28, 2023 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect unused `bindgen`/`riddle` filters #2634

Detect unused `bindgen`/`riddle` filters #2634

kennykerr commented Aug 28, 2023 •

edited

Loading

ChrisDenton left a comment

riverar Aug 28, 2023 •

edited

Loading

ChrisDenton Aug 28, 2023

kennykerr commented Aug 28, 2023

kennykerr commented Aug 28, 2023

Detect unused bindgen/riddle filters #2634

Detect unused bindgen/riddle filters #2634

Conversation

kennykerr commented Aug 28, 2023 • edited Loading

ChrisDenton left a comment

Choose a reason for hiding this comment

riverar Aug 28, 2023 • edited Loading

Choose a reason for hiding this comment

ChrisDenton Aug 28, 2023

Choose a reason for hiding this comment

kennykerr commented Aug 28, 2023

kennykerr commented Aug 28, 2023

Detect unused `bindgen`/`riddle` filters #2634

Detect unused `bindgen`/`riddle` filters #2634

kennykerr commented Aug 28, 2023 •

edited

Loading

riverar Aug 28, 2023 •

edited

Loading