Produce conservative enum definitions in standalone code generation #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
changed the title
This was referenced Apr 5, 2023
Closed
ChrisDenton
reviewed
Apr 7, 2023
| @@ -19,6 +19,7 @@ pub fn standalone(names: &[&str]) -> String { | |||
|
|
|||
| let mut type_names = BTreeSet::new(); | |||
| let mut core_types = BTreeSet::new(); | |||
| let mut enums = BTreeMap::new(); | |||
There was a problem hiding this comment.
@kennykerr I think you might have meant this to be a Vec? Otherwise this will overwrite the entry instead of adding to it:
enums.insert(enum_name, type_name.name);There was a problem hiding this comment.
Ah, good catch - will fix asap.
There was a problem hiding this comment.
Here's the fix: #2434 - I use sorted containers to ensure that the generated code is reproducible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unscoped enumeration types are now generated without generating all of the enumerator constants. Practically, this means that if you directly or indirectly refer to a type like
WIN32_ERROR- with its many constants - that you will only get theWIN32_ERRORtype itself and will need to request any constants directly. This can greatly reduce the overall size of the code produced with standalone code generation.Fixes: #2409