Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samples readme #1980

Closed
wants to merge 1 commit into from
Closed

Add samples readme #1980

wants to merge 1 commit into from

Conversation

kennykerr
Copy link
Collaborator

This adds a brief explanation for how to find the correct samples for a given release of the windows and windows-sys crates.

Fixes: #1977

@kennykerr
Copy link
Collaborator Author

Sigh. Cargo 1.46 - used to validate windows-sys - doesn't like a readme.md in the workspace.

@kennykerr kennykerr closed this Aug 23, 2022
@rylev
Copy link
Contributor

rylev commented Aug 26, 2022

@kennykerr what was the error you encountered? Seems strange that a markdown file would trip up cargo.

@ChrisDenton
Copy link
Collaborator

You may need to add an exclude to windows-rs/Cargo.toml otherwise it's matched by the crates/samples/* member. See the Cargo docs.

@rylev rylev deleted the samples branch August 26, 2022 15:03
@kennykerr
Copy link
Collaborator Author

@rylev
Copy link
Contributor

rylev commented Aug 26, 2022

@ChrisDenton's suggestion is exactly what you need to do:

[workspace]
members = [
  "samples/*",
  # ...
]
exclude = ["samples/readme.md"]

@kennykerr
Copy link
Collaborator Author

Its interesting that it works with newer versions of cargo, but that's a reasonable workaround - thanks!

@kennykerr
Copy link
Collaborator Author

This issue was also addressed some time between 1.46 and 1.49 so I think I'll just update the MSRV of windows-sys and avoid complicating the workspace. #1987

@riverar
Copy link
Collaborator

riverar commented Aug 26, 2022

This particular issue was fixed in Cargo 1.47 (rust-lang/cargo#8511)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: /crates/samples/create_window/src/main.rs Line 40 expected *-ptr, found enum Option
4 participants