Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new windows-sys? #3006

Closed
evmar opened this issue Apr 19, 2024 · 4 comments
Closed

Release new windows-sys? #3006

evmar opened this issue Apr 19, 2024 · 4 comments
Labels
question Further information is requested

Comments

@evmar
Copy link

evmar commented Apr 19, 2024

Suggestion

https://crates.io/crates/windows-sys/versions says windows-sys is at 0.52.0, while windows is at 0.56.0 per https://crates.io/crates/windows/versions
@evmar evmar added the enhancement New feature or request label Apr 19, 2024
@kennykerr
Copy link
Collaborator

The windows-sys crate is not published regularly to avoid version churn.

@kennykerr kennykerr added question Further information is requested and removed enhancement New feature or request labels Apr 19, 2024
@evmar
Copy link
Author

evmar commented Apr 19, 2024

I was hoping specifically for the change in

7219668#diff-7ed016d28949e2cee1c68a4ad5101d5c9f8d3766fb3e6e8e7310f9d273922d2eL3

which is necessary to use windows-sys when targeting i586-pc-windows-msvc

@kennykerr
Copy link
Collaborator

I simplified that further in #2973 and that's included with the latest release of the windows-targets crate.

@evmar
Copy link
Author

evmar commented Apr 19, 2024

Ah I see, I can use windows-sys 0.52.0 but specify windows-targets at 0.52.5 as an additional dependency and windows-sys will pick it up. Thanks for your help!

@evmar evmar closed this as completed Apr 19, 2024
evmar added a commit to evmar/retrowin32 that referenced this issue Apr 20, 2024
@evmar
cargo update windows-targets to pick up i586 fix
4a25bb1 
This is a transitive dep of windows-sys, but windows-sys has no
corresponding updated version.

microsoft/windows-rs#3006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evmar @kennykerr