Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine send/recv flags into new SEND_RECV_FLAGS enumeration #893

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Combine send/recv flags into new SEND_RECV_FLAGS enumeration #893

merged 1 commit into from
Apr 17, 2022

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Apr 16, 2022

Combines send/recv flags into new SEND_RECV_FLAGS enumeration of integers and associates with send/recv functions.

Fixes: #849

Metadata diff:

Windows.Win32.Networking.WinSock.SEND_FLAGS not found in 2nd winmd
Windows.Win32.Networking.WinSock.SEND_RECV_FLAGS not found in 1st winmd
Windows.Win32.Networking.WinSock.Apis.MSG_PEEK not found in 2nd winmd
Windows.Win32.Networking.WinSock.Apis.MSG_WAITALL not found in 2nd winmd
Windows.Win32.Networking.WinSock.Apis.MSG_PUSH_IMMEDIATE not found in 2nd winmd
Windows.Win32.Networking.WinSock.Apis.recv : flags...Int32 => SEND_RECV_FLAGS
Windows.Win32.Networking.WinSock.Apis.send : flags...SEND_FLAGS => SEND_RECV_FLAGS

@mikebattista Can you double-check this satisfies what was discussed in #849? Thanks!

@mikebattista mikebattista merged commit f3f87a5 into microsoft:master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebattista mikebattista mikebattista approved these changes

@sotteson1 sotteson1 Awaiting requested review from sotteson1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signed vs. unsigned flags types in winsock2 APIs
2 participants
@riverar @mikebattista