-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark DXGI_SWAP_CHAIN_DESC1::Flags
as DXGI_SWAP_CHAIN_FLAG
type
#1583
Mark DXGI_SWAP_CHAIN_DESC1::Flags
as DXGI_SWAP_CHAIN_FLAG
type
#1583
Conversation
The types don't match here. You should use the
|
Thanks for suggesting that @mikebattista - it looks like the change only landed 3 days ago while this PR is based on commits from ± a week ago because I got many errors when making this change on At least this got me the right value in ILSpy without errors there, but will try again after rebasing on |
This is currently a `UINT` followed by a comment stating the actual enumeration type that contains the possible flag bits.
34a0f30
to
85f54c0
Compare
Yes a clean build would be a good idea if you're having issues. Also make sure you update the baseline per the instructions at the end of the build. |
👍 I'll give it a try the next time I boot into Windows... (Changes pushed here are per request above, but not build-tested locally) |
85f54c0
to
336519a
Compare
@mikebattista looks like it is working as expected:
And according to IlSpy: public struct DXGI_SWAP_CHAIN_DESC1
{
// ...
[AssociatedEnum("DXGI_SWAP_CHAIN_FLAG")]
public uint Flags;
} |
Thanks! |
This is currently a
UINT
followed by a comment stating the actual enumeration type that contains the possible flag bits.