LCS_WINDOWS_COLOR_SPACE and LCS_sRGB are missing for LcsCsType enum constants

[rhysd]

Suggestion

LOGCOLORSPACEA struct has lcsCSType field. The field expects LCS_CALIBRATED_RGB or LCS_sRGB or LCS_WINDOWS_COLOR_SPACE enum constants.

https://learn.microsoft.com/en-us/windows/win32/api/wingdi/ns-wingdi-logcolorspacea

windows-rs only defines LCS_CALIBRATED_RGB. Can we add LCS_sRGB and LCS_WINDOWS_COLOR_SPACE constants?

winapi crate defines these constants:

• https://docs.rs/winapi/latest/winapi/um/wingdi/constant.LCS_WINDOWS_COLOR_SPACE.html
• https://docs.rs/winapi/latest/winapi/um/wingdi/constant.LCS_CALIBRATED_RGB.html
• https://docs.rs/winapi/latest/winapi/um/wingdi/constant.LCS_sRGB.html

[kennykerr]

Looks like we're missing these from the Win32 metadata. Will transfer this issue for their consideration.

[rhysd]

Thank you for handling this issue. I got it.

[mikebattista]

win32metadata/generation/WinSDK/RecompiledIdlHeaders/um/wingdi.h

Lines 669 to 675 in 53c95c5

	#define LCS_sRGB 'sRGB'
	#define LCS_WINDOWS_COLOR_SPACE 'Win ' // Windows default color space
	#pragma region Application Family
	#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_APP | WINAPI_PARTITION_SYSTEM)
	typedef LONG LCSCSTYPE;

Are these strings treated as ints? If so, what's their value?

[rhysd]

They are multicharacter literals, not strings.

https://learn.microsoft.com/en-us/cpp/cpp/string-and-character-literals-cpp?view=msvc-170#microsoft-specific

[rhysd]

what's their value?

According to winapi crate,

pub const LCS_sRGB: LCSCSTYPE = 0x7352_4742;
pub const LCS_WINDOWS_COLOR_SPACE: LCSCSTYPE = 0x5769_6E20;

[mikebattista]

Thanks. I will group these all into an LCSCSTYPE enum.