rdp-backend: Fix incorrect keyboard variant for Canadian French #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hideyukn88
changed the title
|
@raphaelboudreault, thank you very much for submitting PR. In order to accept your PR, you will need to accept Microsoft Contributor agreement, please see https://github.com/microsoft/ContributorLicenseAgreement, once agreed. you will need to post specific keyword comment in this PR described as https://github.com/microsoft/ContributorLicenseAgreement#accepting, thanks! |
hideyukn88
approved these changes
Jun 23, 2023
|
@hideyukn88 I believe I already signed the CLA since the cla-bot check passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Canadian French RDP keyboard mapping to XKB is currently incorrect in WSLg. While it should resolve to layout 'ca' without any variant (Canadian French, https://learn.microsoft.com/en-us/globalization/keyboards/kbdca), it instead resolves as layout 'ca' variant 'fr-legacy' (Canadian French (Legacy), https://learn.microsoft.com/en-us/globalization/keyboards/kbdfc), which is already defined in the mapping for
KBD_CANADIAN_FRENCH_LEGACY. This PR makes the correction.Note that I didn't run nor test the code. I believe the correction is OK, but it should be validated. Thanks!