Update AzureDevOps.yml #5249
Merged
Update AzureDevOps.yml #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing usage of PAT with Entra ID service principal via federated identity
nohwnd
reviewed
Sep 3, 2024
| run: | ||
| # The resource ID for Azure DevOps is always 499b84ac-1321-427f-aa17-267ca6975798 | ||
| # https://learn.microsoft.com/azure/devops/integrate/get-started/authentication/service-principal-managed-identity | ||
| echo "ado_token=$(az account get-access-token --resource 499b84ac-1321-427f-aa17-267ca6975798 --query "accessToken" --output tsv)" >> $GITHUB_ENV |
There was a problem hiding this comment.
can the resource id be part of you secrets?
Or can the action below use the azure login to carry out the task?
There was a problem hiding this comment.
sure, but resource id is a public information so there isn't any real need hiding it.
nohwnd
approved these changes
Sep 4, 2024
nohwnd
reviewed
Sep 4, 2024
| run: | ||
| # The resource ID for Azure DevOps is always 499b84ac-1321-427f-aa17-267ca6975798 | ||
| # https://learn.microsoft.com/azure/devops/integrate/get-started/authentication/service-principal-managed-identity | ||
| echo "ado_token=$(az account get-access-token --resource 499b84ac-1321-427f-aa17-267ca6975798 --query "accessToken" --output tsv)" >> $GITHUB_ENV |
There was a problem hiding this comment.
nit:
Suggested change
| echo "ado_token=$(az account get-access-token --resource 499b84ac-1321-427f-aa17-267ca6975798 --query "accessToken" --output tsv)" >> $GITHUB_ENV | |
| echo "ADO_TOKEN=$(az account get-access-token --resource 499b84ac-1321-427f-aa17-267ca6975798 --query "accessToken" --output tsv)" >> $GITHUB_ENV |
nohwnd
reviewed
Sep 4, 2024
| - uses: pavelhorak/github-actions-issue-to-work-item@main | ||
| env: | ||
| ado_token: "${{ secrets.ADO_PERSONAL_ACCESS_TOKEN }}" | ||
| ado_token: "${{ env.ado_token }}" |
There was a problem hiding this comment.
nit:
Suggested change
| ado_token: "${{ env.ado_token }}" | |
| ado_token: "${{ env.ADO_TOKEN }}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing usage of PAT with Entra ID service principal via federated identity