-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take System dlls from testhost folder #4610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on windows and on linux and can run tests in both.
|
nohwnd
approved these changes
Jul 18, 2023
Hi Will this fix make it into .NET 8? I tested with the latest daily SDK for .NET 8 RC1, and it still fails.
I see the version is 17.7.0 while the version that you tested is 17.8.0. |
This was referenced Jul 30, 2023
nohwnd
pushed a commit
to nohwnd/vstest
that referenced
this pull request
Aug 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For
TestHostNetFramework
folder, embed dlls from the various net framework folders of the testhost projects rather than from netstandard library package.Related issue
Relates to AB#1843962
Fix #4549