Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkingDirectory Fix #317

Merged
merged 4 commits into from
Jan 6, 2017
Merged

WorkingDirectory Fix #317

merged 4 commits into from
Jan 6, 2017

Conversation

singhsarab
Copy link
Contributor

Fixed the working directory for the dotnet.exe to source directory.

@singhsarab singhsarab requested a review from codito January 5, 2017 17:25
@codito
Copy link
Contributor

codito commented Jan 6, 2017

👍 Kindly ensure the following before merge:

What is the output of Directory.GetCurrentDirectory() in a test targeting net46 and netcoreapp1.0? Is it the same or different?

{
// Absolute path to the source directory
var sourcePath = Path.Combine($"{Path.DirectorySeparatorChar}tmp", "test.dll");
this.mockFileHelper.Setup(ph => ph.Exists(@"\tmp\testhost.dll")).Returns(true);
var startInfo = this.dotnetHostManager.GetTestHostProcessStartInfo(new[] { sourcePath }, null, this.defaultConnectionInfo);

Assert.AreEqual(Directory.GetCurrentDirectory(), startInfo.WorkingDirectory);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove space

@singhsarab singhsarab merged commit dd816d0 into microsoft:master Jan 6, 2017
@singhsarab
Copy link
Contributor Author

Validated the related issues.
Output for Directory.CurrentDirectory for net46 and netcoreapp1.0 both are similar, as in point to source directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants