Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to auto property #10365

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Convert to auto property #10365

merged 4 commits into from
Oct 3, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Oct 2, 2024

Description

Fix #10364

@NikolaMilosavljevic
Copy link
Member

There's another of this type of issues: #10364 (comment)

I'm not sure why build is not reporting all issues at once.

@nohwnd
Copy link
Member Author

nohwnd commented Oct 3, 2024

Fixing it in the analyzer suggested way causes more problems than it solves, I am downgrading the severity of to suggestion.

@nohwnd
Copy link
Member Author

nohwnd commented Oct 3, 2024

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@nohwnd nohwnd merged commit 5e82d23 into microsoft:main Oct 3, 2024
4 of 7 checks passed
@NikolaMilosavljevic
Copy link
Member

@nohwnd this is needed in .NET 9.0 release (vstest 17.12). Is there a backport PR to rel/17.12 branch?

nohwnd added a commit that referenced this pull request Oct 4, 2024
* Convert to auto property

* Another field

* revert

* suppress
@nohwnd
Copy link
Member Author

nohwnd commented Oct 4, 2024

I just cherry picked into rel/17.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[9.0] Source-build issue in stage 2 build
2 participants