Skip to content

Commit

Permalink
Set NetCurrent so that it doesn't roll forward automatically (#10622)
Browse files Browse the repository at this point in the history
* Set NetCurrent so that it doesn't roll forward automatically

The VSTest repo can't use a floating NetCurrent value as the NetCurrent TFM is actually hardcoded in a number of places => .nuspec files. Set it to net9.0 explicitly so that the build continues to work with a .NET 10 SDK and Arcade 10 SDK (which is used inside the VMR).

Don't hardcode the value when building from source as in that configuration, the TFM needs to actually target the very latest.

* Update Directory.Build.props

---------

Co-authored-by: Jakub Jareš <[email protected]>
  • Loading branch information
ViktorHofer and nohwnd authored Dec 10, 2024
1 parent 7d34b30 commit fc78508
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@
<PropertyGroup>
<!-- Naming is based on dotnet/runtime one -->
<NetFrameworkMinimum>net462</NetFrameworkMinimum>
<!-- When not building from source, hardcode the NetCurrent TFM value as it is hardcoded in a number of places, i.e. nuspec files. -->
<NetCurrent Condition="'$(DotNetBuildSourceOnly)' != 'true'">net9.0</NetCurrent>
<NetCoreAppMinimum>netcoreapp3.1</NetCoreAppMinimum>
<!--
Arcade is making things hard to work with. This property is unset when its value is equal to NetMinimum.
Expand Down

0 comments on commit fc78508

Please sign in to comment.