Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show errors for shell provided tasks #97686

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented May 13, 2020

Fixes #97155

@alexr00 alexr00 self-assigned this May 13, 2020
@alexr00 alexr00 added this to the April 2020 Recovery milestone May 13, 2020
@alexr00
Copy link
Member Author

alexr00 commented May 13, 2020

Full context:
The new task quick pick requires that task providers only provide task of they type they say the provide. It will still function if task providers provide other task types, but the Recent tasks won't work.
This is always true for custom task types, but for the built in shell and process task types Recent tasks will still work. We should provide the error in the output but not show the notification that says there is info in the output.

@dbaeumer dbaeumer self-requested a review May 13, 2020 08:50
@alexr00 alexr00 merged commit 9581e7a into release/1.45 May 13, 2020
@alexr00 alexr00 deleted the alexr00/issue97155 branch May 13, 2020 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants